Repository navigation
Appends slashes to urls - #1064
umurkontaci wants to merge 1 commit into
Conversation
|
wat? A slash after the query? That doesn't look right. |
ghost
assigned
|
Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): For corporations (print, sign and scan+email, fax or mail): |
|
So after thinking about this some more, we are not going to accept this. Here are the reasons
|
There was a problem hiding this comment.
Are you sure? You append a slash at the end of the url.
return url + (query.length ? '?' + query.join('&') : '') + '/';
foo?query1=1&query2=2/
I would made a bid for a line 297
There was a problem hiding this comment.
This is an old pull request has been rejected already, I've made a local fix for django users but raises other issues.
There was a problem hiding this comment.
Still facing the trailing slash issue with Django Rest Framework with Angular Resource.
Angular intenionally removes slashes from urls defined in ngResource and this causes bugs and problems in frameworks like django. It simply adds slashes to urls for it work.